Skip to content

Make a PR description template.#1659

Merged
dannywillems merged 1 commit intodevelopfrom
rp/pr-template
Dec 9, 2025
Merged

Make a PR description template.#1659
dannywillems merged 1 commit intodevelopfrom
rp/pr-template

Conversation

@richardpringle
Copy link
Copy Markdown
Contributor

@richardpringle richardpringle commented Nov 24, 2025

Description

Adding a PR template so that we can have better PR descriptions. This one might be a litte overkill to start, but we can always iterate.

Related Issue(s)

N/A

Type of Change

  • Process

Testing

N/A

Changelog Entry

Not needed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 24, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 24, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 38eb6e81670eaaa06bd4b1456baa041930e4f840

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 38eb6e81670eaaa06bd4b1456baa041930e4f840)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

dannywillems
dannywillems previously approved these changes Nov 26, 2025
View reviewed changes
@dannywillems dannywillems disabled auto-merge December 9, 2025 18:08
@dannywillems dannywillems merged commit 29b09e1 into develop Dec 9, 2025
175 of 183 checks passed
@dannywillems dannywillems deleted the rp/pr-template branch December 9, 2025 18:08
@dannywillems dannywillems moved this to Done in Rust node Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dannywillems dannywillems dannywillems approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@richardpringle richardpringle

Labels

no changelog

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richardpringle @dannywillems